feat(tendermint): validators RPC #2310

onur-ozkan · 2025-01-02T09:03:49Z

This is the initial implementation related to Tendermint staking feature on KDF. Remaining parts will be added gradually one by one similar to the validators RPC in this PR.

e.g., RPC payload structure:

komodo-defi-framework/mm2src/mm2_test_helpers/src/for_tests.rs

Lines 3102 to 3112 in 4c63f6e

    
           let request = json!({ 
        
               "userpass": mm.userpass, 
        
               "method": rpc_endpoint, 
        
               "mmrpc": "2.0", 
        
               "params": { 
        
                   "ticker": coin, 
        
                   "filter_by_status": filter_by_status, 
        
                   "limit": limit, 
        
                   "page_number": page_number 
        
               } 
        
           });

filter_by_status can be set to one of All, Bonded and Unbonded. Default is All.

Explanation of Bonded and Unbonded statuses:

komodo-defi-framework/mm2src/coins/rpc_command/tendermint/staking.rs

Lines 12 to 18 in 43dbf48

    
               /// Validator is in the active set and participates in consensus. 
        
               #[default] 
        
               Bonded, 
        
               /// Validator is not in the active set and does not participate in consensus. 
        
               /// Accordingly, they do not receive rewards and cannot be slashed. 
        
               /// It is possible to delegate tokens to a validator in this state. 
        
               Unbonded,

Signed-off-by: onur-ozkan <[email protected]>

mm2src/coins/rpc_command/tendermint/staking.rs

borngraced

great work!

Signed-off-by: onur-ozkan <[email protected]>

mariocynicys

thank YOU :)

mm2src/mm2_test_helpers/src/for_tests.rs

mm2src/mm2_main/tests/docker_tests/tendermint_tests.rs

mm2src/coins/tendermint/tendermint_coin.rs

mm2src/coins/rpc_command/tendermint/staking.rs

Signed-off-by: onur-ozkan <[email protected]>

mariocynicys

Thanks
LGTM!

* dev: feat(tendermint): validators RPC (#2310) chore(CI): validate Cargo lock file (#2309) test(P2P): add test for peer time sync validation (#2304)

* dev: (35 commits) fix(crypto): allow non bip39 mnemonics storage (KomodoPlatform#2312) fix(legacy_swap): check for existing maker/taker payment before timeout (KomodoPlatform#2283) feat(tendermint): validators RPC (KomodoPlatform#2310) chore(CI): validate Cargo lock file (KomodoPlatform#2309) test(P2P): add test for peer time sync validation (KomodoPlatform#2304) fix mm2_p2p dev build (KomodoPlatform#2311) update Cargo.lock (KomodoPlatform#2308) chore(CI): unlock wasm-pack version (KomodoPlatform#2307) add `wasm` feature on WASM for timed-map (KomodoPlatform#2306) replace broken rpc link (KomodoPlatform#2305) chore(eth-websocket): remove some unnecessary wrappers (KomodoPlatform#2291) improvement(CI): switch to proper rust caching (KomodoPlatform#2303) fix(wasm): add test-ext-api feature to mm2_main and mm2_bin_lib tomls (KomodoPlatform#2295) chore(ci): Update docker build for wasm (KomodoPlatform#2294) chore(p2p): follow-up nits (KomodoPlatform#2302) feat(p2p): ensure time synchronization in the network (KomodoPlatform#2255) bump libp2p (KomodoPlatform#2296) chore(adex-cli): use "Komodo DeFi Framework" name in adex_cli (KomodoPlatform#2290) chore(ctx): replace gstuff constructible with oncelock (KomodoPlatform#2267) don't rely on core (KomodoPlatform#2289) ...

* save dev state Signed-off-by: onur-ozkan <[email protected]> * save dev state Signed-off-by: onur-ozkan <[email protected]> * make proto types serializable for RPC endpoint Signed-off-by: onur-ozkan <[email protected]> * remove dummy test Signed-off-by: onur-ozkan <[email protected]> * add RPC error type Signed-off-by: onur-ozkan <[email protected]> * add TODO Signed-off-by: onur-ozkan <[email protected]> * fix status filtering Signed-off-by: onur-ozkan <[email protected]> * fix clippy warn Signed-off-by: onur-ozkan <[email protected]> * resolve `todo!()`s Signed-off-by: onur-ozkan <[email protected]> * remove inline attribute Signed-off-by: onur-ozkan <[email protected]> * improve `validators_rpc` Signed-off-by: onur-ozkan <[email protected]> * add coverage for tendermint_validators RPC Signed-off-by: onur-ozkan <[email protected]> * apply nit changes Signed-off-by: onur-ozkan <[email protected]> * document `ValidatorStatus` Signed-off-by: onur-ozkan <[email protected]> * use proper error variant on coin filtering Signed-off-by: onur-ozkan <[email protected]> * apply nits Signed-off-by: onur-ozkan <[email protected]> --------- Signed-off-by: onur-ozkan <[email protected]>

onur-ozkan added 7 commits December 31, 2024 14:16

save dev state

9fc3319

Signed-off-by: onur-ozkan <[email protected]>

save dev state

a6ebe1c

Signed-off-by: onur-ozkan <[email protected]>

make proto types serializable for RPC endpoint

9198049

Signed-off-by: onur-ozkan <[email protected]>

remove dummy test

b48c1ba

Signed-off-by: onur-ozkan <[email protected]>

add RPC error type

2470594

Signed-off-by: onur-ozkan <[email protected]>

add TODO

c4df52a

Signed-off-by: onur-ozkan <[email protected]>

fix status filtering

95d008b

Signed-off-by: onur-ozkan <[email protected]>

onur-ozkan added status: in progress feature: protocol feature: RPC labels Jan 2, 2025

onur-ozkan added 5 commits January 2, 2025 12:06

fix clippy warn

61b1654

Signed-off-by: onur-ozkan <[email protected]>

resolve todo!()s

8d59f4d

Signed-off-by: onur-ozkan <[email protected]>

remove inline attribute

05eb07e

Signed-off-by: onur-ozkan <[email protected]>

improve validators_rpc

838bee4

Signed-off-by: onur-ozkan <[email protected]>

add coverage for tendermint_validators RPC

ee20b9a

Signed-off-by: onur-ozkan <[email protected]>

onur-ozkan force-pushed the validator-rpcs branch from 9d0e6c8 to ee20b9a Compare January 2, 2025 11:26

apply nit changes

4c63f6e

Signed-off-by: onur-ozkan <[email protected]>

onur-ozkan added status: pending review and removed status: in progress labels Jan 6, 2025

onur-ozkan marked this pull request as ready for review January 6, 2025 06:09

document ValidatorStatus

43dbf48

Signed-off-by: onur-ozkan <[email protected]>

borngraced reviewed Jan 6, 2025

View reviewed changes

mm2src/coins/rpc_command/tendermint/staking.rs Outdated Show resolved Hide resolved

borngraced previously approved these changes Jan 6, 2025

View reviewed changes

use proper error variant on coin filtering

db5cff6

Signed-off-by: onur-ozkan <[email protected]>

onur-ozkan dismissed borngraced’s stale review via db5cff6 January 6, 2025 12:27

mariocynicys reviewed Jan 6, 2025

View reviewed changes

apply nits

96306cc

Signed-off-by: onur-ozkan <[email protected]>

onur-ozkan force-pushed the validator-rpcs branch from 9006269 to 96306cc Compare January 7, 2025 08:09

mariocynicys approved these changes Jan 8, 2025

View reviewed changes

onur-ozkan merged commit 1908a2e into dev Jan 8, 2025
16 of 23 checks passed

onur-ozkan deleted the validator-rpcs branch January 8, 2025 08:12

dimxy added a commit that referenced this pull request Jan 8, 2025

Merge branch 'dev' into fix-utxo-tx-fee-for-change

455403c

* dev: feat(tendermint): validators RPC (#2310) chore(CI): validate Cargo lock file (#2309) test(P2P): add test for peer time sync validation (#2304)

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(tendermint): validators RPC #2310

feat(tendermint): validators RPC #2310

onur-ozkan commented Jan 2, 2025 •

edited

Loading

borngraced left a comment

mariocynicys left a comment

mariocynicys left a comment

	let request = json!({
	"userpass": mm.userpass,
	"method": rpc_endpoint,
	"mmrpc": "2.0",
	"params": {
	"ticker": coin,
	"filter_by_status": filter_by_status,
	"limit": limit,
	"page_number": page_number
	}
	});

	/// Validator is in the active set and participates in consensus.
	#[default]
	Bonded,
	/// Validator is not in the active set and does not participate in consensus.
	/// Accordingly, they do not receive rewards and cannot be slashed.
	/// It is possible to delegate tokens to a validator in this state.
	Unbonded,

feat(tendermint): validators RPC #2310

feat(tendermint): validators RPC #2310

Conversation

onur-ozkan commented Jan 2, 2025 • edited Loading

borngraced left a comment

Choose a reason for hiding this comment

mariocynicys left a comment

Choose a reason for hiding this comment

mariocynicys left a comment

Choose a reason for hiding this comment

onur-ozkan commented Jan 2, 2025 •

edited

Loading